Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact entity configuration metadata #4862

Merged
merged 8 commits into from
Sep 12, 2022

Conversation

jamesdphillips
Copy link
Contributor

What is this change?

Redacts entity config resource's metadata using configured list.

Why is this change necessary?

Redacts entity config when fetching entity config reources.

Were there any complications while making this change?

  • Unfortunate but I pulled FoundInArray into core/v3 to avoid cyclical dependency
  • I felt this was best handled in the API package, hopefully this avoids any unintentional regressions in the future.
  • Because the base module's dependencies weren't updated, the API package tests broke after the recently entity config RBAC change ([GraphQL] List entity config & state resources #4808)

How did you verify this change?

Unit tests & sanity check.

Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
@jamesdphillips jamesdphillips added component:web-ui Sensu dashboard improvements component:api Sensu API improvements labels Sep 12, 2022
Signed-off-by: James Phillips <jamesdphillips@gmail.com>
@jamesdphillips jamesdphillips marked this pull request as ready for review September 12, 2022 19:24
@jamesdphillips
Copy link
Contributor Author

Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you please also apply to main?

@jamesdphillips jamesdphillips merged commit 7a13587 into release/6.8 Sep 12, 2022
@jamesdphillips jamesdphillips deleted the jdp/redact-entity-config branch September 12, 2022 20:53
c-kruse pushed a commit that referenced this pull request Sep 29, 2022
Heavy merge guessing by CK.

Signed-off-by: James Phillips <jamesdphillips@gmail.com>
(cherry picked from commit 7a13587)
c-kruse added a commit that referenced this pull request Sep 29, 2022
Original work (#4862) adapted for 7.x track

Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
c-kruse added a commit that referenced this pull request Sep 29, 2022
Original work (#4862) adapted for 7.x track

Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
c-kruse pushed a commit that referenced this pull request Sep 30, 2022
Heavy merge guessing by CK.

Signed-off-by: James Phillips <jamesdphillips@gmail.com>
(cherry picked from commit 7a13587)
c-kruse added a commit that referenced this pull request Sep 30, 2022
Original work (#4862) adapted for 7.x track

Signed-off-by: Christian Kruse <ctkruse99@gmail.com>

go mod tidy

Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
c-kruse pushed a commit that referenced this pull request Oct 5, 2022
Heavy merge guessing by CK.

Signed-off-by: James Phillips <jamesdphillips@gmail.com>
(cherry picked from commit 7a13587)
c-kruse added a commit that referenced this pull request Oct 5, 2022
Original work (#4862) adapted for 7.x track

Signed-off-by: Christian Kruse <ctkruse99@gmail.com>

go mod tidy

Signed-off-by: Christian Kruse <ctkruse99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api Sensu API improvements component:web-ui Sensu dashboard improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants